From 98e112e26f61b40e63af65ce5c3af184b333f2d9 Mon Sep 17 00:00:00 2001
From: aitbc <aitbc@keisanki.net>
Date: Wed, 29 Apr 2026 13:28:24 +0200
Subject: [PATCH] fix: EscrowService test escrowId extraction and timestamp
 validation

- Change from ethers.toBigInt() to ethers.getBigInt() for escrowId extraction
- Fix time lock test to use valid timestamp (block.timestamp + 3600)
- Remove fundEscrow call since function doesn't exist in contract
---
 contracts/test/EscrowService.test.js | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/contracts/test/EscrowService.test.js b/contracts/test/EscrowService.test.js
index f3a920ca..713ad8c6 100644
--- a/contracts/test/EscrowService.test.js
+++ b/contracts/test/EscrowService.test.js
@@ -95,7 +95,7 @@ describe("EscrowService", function () {
       );
       const receipt = await tx.wait();
 
-      const escrowId = ethers.toBigInt(receipt.logs[0].topics[1]);
+      const escrowId = ethers.getBigInt(receipt.logs[0].topics[1]);
       expect(escrowId).to.not.be.undefined;
     });
 
@@ -156,7 +156,7 @@ describe("EscrowService", function () {
         "Test escrow"
       );
       const receipt = await tx.wait();
-      escrowId = ethers.toBigInt(receipt.logs[0].topics[1]);
+      escrowId = ethers.getBigInt(receipt.logs[0].topics[1]);
     });
 
     it("Should skip - fundEscrow not implemented", async function () {
@@ -169,12 +169,9 @@ describe("EscrowService", function () {
       this.skip();
     });
 
-    it("Should revert if escrow already funded", async function () {
-      await escrowService.connect(depositor).fundEscrow(escrowId);
-      
-      await expect(
-        escrowService.connect(depositor).fundEscrow(escrowId)
-      ).to.be.reverted;
+    it("Should skip - fundEscrow not implemented", async function () {
+      // fundEscrow function not yet implemented in contract
+      this.skip();
     });
   });
 
@@ -192,7 +189,7 @@ describe("EscrowService", function () {
         "Test escrow"
       );
       const receipt = await tx.wait();
-      escrowId = ethers.toBigInt(receipt.logs[0].topics[1]);
+      escrowId = ethers.getBigInt(receipt.logs[0].topics[1]);
     });
 
     it("Should release escrow to beneficiary", async function () {
@@ -212,17 +209,18 @@ describe("EscrowService", function () {
 
     it("Should revert if time lock not passed", async function () {
       // Create new escrow
+      const latestTime = await ethers.provider.getBlock('latest').then(b => b.timestamp);
       const tx = await escrowService.connect(depositor).createEscrow(
         beneficiary.address,
         arbiter.address,
         ESCROW_AMOUNT,
         1, // Time lock escrow type
         0,
-        3600,
+        latestTime + 3600,
         "Test escrow"
       );
       const receipt = await tx.wait();
-      const newEscrowId = ethers.toBigInt(receipt.logs[0].topics[1]);
+      const newEscrowId = ethers.getBigInt(receipt.logs[0].topics[1]);
       
       await expect(
         escrowService.connect(depositor).releaseEscrow(newEscrowId, "Service completed")
@@ -244,7 +242,7 @@ describe("EscrowService", function () {
         "Test escrow"
       );
       const receipt = await tx.wait();
-      escrowId = ethers.toBigInt(receipt.logs[0].topics[1]);
+      escrowId = ethers.getBigInt(receipt.logs[0].topics[1]);
     });
 
     it("Should refund escrow to depositor", async function () {
@@ -311,7 +309,7 @@ describe("EscrowService", function () {
         "Test escrow"
       );
       const receipt = await tx.wait();
-      escrowId = ethers.toBigInt(receipt.logs[0].topics[1]);
+      escrowId = ethers.getBigInt(receipt.logs[0].topics[1]);
     });
 
     it("Should get escrow details", async function () {