- Change file mode from 644 to 755 for all project files - Add chain_id parameter to get_balance RPC endpoint with default "ait-devnet" - Rename Miner.extra_meta_data to extra_metadata for consistency
4.7 KiB
Executable File
Disabled Commands Cleanup Analysis
Overview
This document analyzes the currently disabled CLI commands and provides recommendations for cleanup.
Disabled Commands
1. openclaw - Edge Computing Integration
File: cli/aitbc_cli/commands/openclaw.py
Status: Commented out in main.py line 28
Reason: "Temporarily disabled due to command registration issues"
Analysis:
- Size: 604 lines of code
- Functionality: OpenClaw integration with edge computing deployment
- Dependencies: httpx, JSON, time utilities
- Potential Value: High - edge computing is strategic for AITBC
Recommendation: FIX AND RE-ENABLE
- Command registration issues are likely minor (naming conflicts)
- Edge computing integration is valuable for the platform
- Code appears well-structured and complete
2. marketplace_advanced - Advanced Marketplace Features
File: cli/aitbc_cli/commands/marketplace_advanced.py
Status: Commented out in main.py line 29
Reason: "Temporarily disabled due to command registration issues"
Analysis:
- Size: Unknown (file not found in current tree)
- Functionality: Advanced marketplace features
- Potential Value: Medium to High
Recommendation: LOCATE AND EVALUATE
- File appears to be missing from current codebase
- May have been accidentally deleted
- Check git history to recover if valuable
3. marketplace_cmd - Alternative Marketplace Implementation
File: cli/aitbc_cli/commands/marketplace_cmd.py
Status: Exists but disabled (comment in main.py line 18)
Reason: Conflict with main marketplace.py
Analysis:
- Size: 495 lines of code
- Functionality: Global chain marketplace commands
- Dependencies: GlobalChainMarketplace, multichain config
- Conflict: Names conflict with existing
marketplace.py
Recommendation: MERGE OR DELETE
- Compare with existing
marketplace.py - Merge unique features if valuable
- Delete if redundant
Cleanup Action Items
Immediate Actions (High Priority)
-
Fix
openclawregistration# Uncomment line 28 in main.py # from .commands.openclaw import openclaw # cli.add_command(openclaw)- Test for naming conflicts
- Rename if necessary (e.g.,
edge-deploy)
-
Resolve
marketplaceconflict# Compare files diff cli/aitbc_cli/commands/marketplace.py cli/aitbc_cli/commands/marketplace_cmd.py- Merge unique features
- Delete redundant file
-
Locate missing
marketplace_advancedgit log --all -- "**/marketplace_advanced.py" git checkout HEAD~1 -- cli/aitbc_cli/commands/marketplace_advanced.py
Code Quality Improvements
-
Add command registration validation
- Prevent future naming conflicts
- Add unit tests for command registration
-
Document command dependencies
- Add clear documentation for each command
- Include dependency requirements
-
Create command deprecation policy
- Formal process for disabling commands
- Clear timeline for removal
Security Considerations
Current State
- Disabled commands are still present in repository
- No security risk from disabled code
- Potential for confusion among users
Recommendations
- Remove truly unused commands to reduce attack surface
- Keep valuable disabled code in separate branch if needed
- Document reasons for disabling
Testing Requirements
Before re-enabling any disabled command:
- Unit Tests: Verify all functions work correctly
- Integration Tests: Test with live coordinator API
- Command Registration: Ensure no conflicts with existing commands
- Security Review: Validate no security vulnerabilities
- Documentation: Update help text and usage examples
Timeline
| Week | Action | Status |
|---|---|---|
| 1 | Fix openclaw registration issues | 🔄 In Progress |
| 1 | Resolve marketplace command conflicts | 🔄 In Progress |
| 2 | Locate and evaluate marketplace_advanced | ⏳ Pending |
| 2 | Add comprehensive tests | ⏳ Pending |
| 3 | Update documentation | ⏳ Pending |
Risk Assessment
| Command | Risk Level | Action |
|---|---|---|
| openclaw | Low | Re-enable after testing |
| marketplace_cmd | Low | Merge or delete |
| marketplace_advanced | Unknown | Locate and evaluate |
Conclusion
The disabled commands appear to contain valuable functionality that should be restored rather than deleted. The "command registration issues" are likely minor naming conflicts that can be resolved with minimal effort.
Next Steps:
- Fix the registration conflicts
- Test thoroughly
- Re-enable valuable commands
- Remove truly redundant code
This cleanup will improve CLI functionality without compromising security.