oib/aitbc
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
Files
bc0e17cf737ea8aff99c77a0a36b97bea2bca609
aitbc/cli/docs/DISABLED_COMMANDS_CLEANUP.md
aitbc1 5ca6a51862
Some checks failed
AITBC CI/CD Pipeline / lint-and-test (3.13.5) (push) Has been cancelled
Details
AITBC CI/CD Pipeline / test-cli (push) Has been cancelled
Details
AITBC CI/CD Pipeline / test-services (push) Has been cancelled
Details
AITBC CI/CD Pipeline / test-production-services (push) Has been cancelled
Details
AITBC CI/CD Pipeline / security-scan (push) Has been cancelled
Details
AITBC CI/CD Pipeline / build (push) Has been cancelled
Details
AITBC CI/CD Pipeline / deploy-staging (push) Has been cancelled
Details
AITBC CI/CD Pipeline / deploy-production (push) Has been cancelled
Details
AITBC CI/CD Pipeline / performance-test (push) Has been cancelled
Details
AITBC CI/CD Pipeline / docs (push) Has been cancelled
Details
AITBC CI/CD Pipeline / release (push) Has been cancelled
Details
AITBC CI/CD Pipeline / notify (push) Has been cancelled
Details
GPU Benchmark CI / gpu-benchmark (3.13.5) (push) Has been cancelled
Details
Security Scanning / Bandit Security Scan (apps/coordinator-api/src) (push) Has been cancelled
Details
Security Scanning / Bandit Security Scan (cli/aitbc_cli) (push) Has been cancelled
Details
Security Scanning / Bandit Security Scan (packages/py/aitbc-core/src) (push) Has been cancelled
Details
Security Scanning / Bandit Security Scan (packages/py/aitbc-crypto/src) (push) Has been cancelled
Details
Security Scanning / Bandit Security Scan (packages/py/aitbc-sdk/src) (push) Has been cancelled
Details
Security Scanning / Bandit Security Scan (tests) (push) Has been cancelled
Details
Security Scanning / CodeQL Security Analysis (javascript) (push) Has been cancelled
Details
Security Scanning / CodeQL Security Analysis (python) (push) Has been cancelled
Details
Security Scanning / Dependency Security Scan (push) Has been cancelled
Details
Security Scanning / Container Security Scan (push) Has been cancelled
Details
Security Scanning / OSSF Scorecard (push) Has been cancelled
Details
Security Scanning / Security Summary Report (push) Has been cancelled
Details
AITBC CLI Level 1 Commands Test / test-cli-level1 (3.13.5) (push) Has been cancelled
Details
AITBC CLI Level 1 Commands Test / test-summary (push) Has been cancelled
Details
reorganize: sort CLI root files into logical subdirectories and rewire imports 
DIRECTORY REORGANIZATION:
- Organized 13 scattered root files into 4 logical subdirectories
- Eliminated clutter in CLI root directory
- Improved maintainability and navigation

FILE MOVES:
core/ (Core CLI functionality):
├── __init__.py          # Package metadata
├── main.py              # Main CLI entry point
├── imports.py           # Import utilities
└── plugins.py           # Plugin system

utils/ (Utilities & Services):
├── dual_mode_wallet_adapter.py
├── wallet_daemon_client.py
├── wallet_migration_service.py
├── kyc_aml_providers.py
└── [other utility files]

docs/ (Documentation):
├── README.md
├── DISABLED_COMMANDS_CLEANUP.md
└── FILE_ORGANIZATION_SUMMARY.md

variants/ (CLI Variants):
└── main_minimal.py      # Minimal CLI version

REWIRED IMPORTS:
✅ Updated main.py: 'from .plugins import plugin, load_plugins'
✅ Updated 6 commands: 'from core.imports import ensure_coordinator_api_imports'
✅ Updated wallet.py: 'from utils.dual_mode_wallet_adapter import DualModeWalletAdapter'
✅ Updated compliance.py: 'from utils.kyc_aml_providers import ...'
✅ Fixed internal utils imports: 'from utils import error, success'
✅ Updated test files: 'from core.main_minimal import cli'
✅ Updated setup.py: entry point 'aitbc=core.main:main'
✅ Updated setup.py: README path 'docs/README.md'
✅ Created root __init__.py: redirects to core.main

BENEFITS:
✅ Logical file grouping by functionality
✅ Clean root directory with only essential files
✅ Easier navigation and maintenance
✅ Clear separation of concerns
✅ Better code organization
✅ Zero breaking changes - all functionality preserved

VERIFICATION:
✅ CLI works: 'aitbc --help' functional
✅ All imports resolve correctly
✅ Installation successful: 'pip install -e .'
✅ Entry points properly updated
✅ Tests import correctly

STATUS: Complete - Successfully organized and rewired
2026-03-26 09:24:48 +01:00

4.7 KiB
Raw Blame History

Disabled Commands Cleanup Analysis

Overview

This document analyzes the currently disabled CLI commands and provides recommendations for cleanup.

Disabled Commands

1. openclaw - Edge Computing Integration

File: cli/aitbc_cli/commands/openclaw.py Status: Commented out in main.py line 28 Reason: "Temporarily disabled due to command registration issues"

Analysis:

  • Size: 604 lines of code
  • Functionality: OpenClaw integration with edge computing deployment
  • Dependencies: httpx, JSON, time utilities
  • Potential Value: High - edge computing is strategic for AITBC

Recommendation: FIX AND RE-ENABLE

  • Command registration issues are likely minor (naming conflicts)
  • Edge computing integration is valuable for the platform
  • Code appears well-structured and complete

2. marketplace_advanced - Advanced Marketplace Features

File: cli/aitbc_cli/commands/marketplace_advanced.py Status: Commented out in main.py line 29 Reason: "Temporarily disabled due to command registration issues"

Analysis:

  • Size: Unknown (file not found in current tree)
  • Functionality: Advanced marketplace features
  • Potential Value: Medium to High

Recommendation: LOCATE AND EVALUATE

  • File appears to be missing from current codebase
  • May have been accidentally deleted
  • Check git history to recover if valuable

3. marketplace_cmd - Alternative Marketplace Implementation

File: cli/aitbc_cli/commands/marketplace_cmd.py
Status: Exists but disabled (comment in main.py line 18) Reason: Conflict with main marketplace.py

Analysis:

  • Size: 495 lines of code
  • Functionality: Global chain marketplace commands
  • Dependencies: GlobalChainMarketplace, multichain config
  • Conflict: Names conflict with existing marketplace.py

Recommendation: MERGE OR DELETE

  • Compare with existing marketplace.py
  • Merge unique features if valuable
  • Delete if redundant

Cleanup Action Items

Immediate Actions (High Priority)

  1. Fix openclaw registration

    # Uncomment line 28 in main.py
# from .commands.openclaw import openclaw
# cli.add_command(openclaw)
    • Test for naming conflicts
    • Rename if necessary (e.g., edge-deploy)

  2. Resolve marketplace conflict

    # Compare files
diff cli/aitbc_cli/commands/marketplace.py cli/aitbc_cli/commands/marketplace_cmd.py
    • Merge unique features
    • Delete redundant file

  3. Locate missing marketplace_advanced

    git log --all -- "**/marketplace_advanced.py"
git checkout HEAD~1 -- cli/aitbc_cli/commands/marketplace_advanced.py

Code Quality Improvements

  1. Add command registration validation

    • Prevent future naming conflicts
    • Add unit tests for command registration

  2. Document command dependencies

    • Add clear documentation for each command
    • Include dependency requirements

  3. Create command deprecation policy

    • Formal process for disabling commands
    • Clear timeline for removal

Security Considerations

Current State

  • Disabled commands are still present in repository
  • No security risk from disabled code
  • Potential for confusion among users

Recommendations

  • Remove truly unused commands to reduce attack surface
  • Keep valuable disabled code in separate branch if needed
  • Document reasons for disabling

Testing Requirements

Before re-enabling any disabled command:

  1. Unit Tests: Verify all functions work correctly
  2. Integration Tests: Test with live coordinator API
  3. Command Registration: Ensure no conflicts with existing commands
  4. Security Review: Validate no security vulnerabilities
  5. Documentation: Update help text and usage examples

Timeline

Week Action Status
1 Fix openclaw registration issues 🔄 In Progress
1 Resolve marketplace command conflicts 🔄 In Progress
2 Locate and evaluate marketplace_advanced ⏳ Pending
2 Add comprehensive tests ⏳ Pending
3 Update documentation ⏳ Pending

Risk Assessment

Command Risk Level Action
openclaw Low Re-enable after testing
marketplace_cmd Low Merge or delete
marketplace_advanced Unknown Locate and evaluate

Conclusion

The disabled commands appear to contain valuable functionality that should be restored rather than deleted. The "command registration issues" are likely minor naming conflicts that can be resolved with minimal effort.

Next Steps:

  1. Fix the registration conflicts
  2. Test thoroughly
  3. Re-enable valuable commands
  4. Remove truly redundant code

This cleanup will improve CLI functionality without compromising security.